feat: Use phone speaker to produce sound #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neel1998
added
In Progress
neel1998
force-pushed
the
wave_gen_sound
branch
from
ee44f97 to
19c80fd
Compare
CloudyPadmal
approved these changes
Sep 2, 2019
|
@CloudyPadmal can we merge this? |
adityastic
approved these changes
Sep 3, 2019
ho-dor
approved these changes
Sep 7, 2019
makoteq
pushed a commit
to makoteq/pslab-android
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1937 #1165
Changes: Added feature to produce sound using phone speaker
Screenshot/s for the changes:
https://drive.google.com/file/d/1MRU9cBSepwstXNkJvfHau9L7rGFDxriv/view?usp=sharing
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
wave_gen_sound.zip
@CloudyPadmal @mariobehling this feature is complete for now. As @mariobehling mentioned in last meet we can build it up from here to allow user to play/view multiple waves simultaneously. Please review.