feat: Add wave generator preview #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neel1998
force-pushed
the
wave_gen_preview
branch
from
2861763 to
92289a4
Compare
neel1998
added
Status: Review Required
|
fixing codacy in a minute... |
|
Nice. For phase, would be better if we can show a reference waveform and with respect to that the changes. |
|
Oh okay. I can do that.. i will keep the reference wave with zero phase and grey color. Sounds right? |
|
Yes. And for vertical axis labels, make them 0V at the bottom and 5V at top |
I was thinking of removing the y axis labels. Since we can change the amplitude in oscilloscope. These labels might confuse the users |
neel1998
force-pushed
the
wave_gen_preview
branch
from
92289a4 to
4477075
Compare
|
@CloudyPadmal I have added reference wave as you suggested... Have updated GIFs and apk. |
|
@mariobehling please review and merge this. I need a function implemented in this PR to add sound feature in wave generator. Thanks |
CloudyPadmal
added
Enhancement
makoteq
pushed a commit
to makoteq/pslab-android
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1938
Changes: wave generator preview working fine
Screenshot/s for the changes:
Analog Mode
Digital Mode
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
wave_gen_preview.zip
@CloudyPadmal @mariobehling I have added the preview feature to the wave generator UI. It is really looking good. Please review. I have made a getSamplePoints() function which I will use again to produce sound for different waves for the issue #1937