Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: readme images changed #1958

Merged

Conversation

neel1998
Copy link
Member

Fixes #1953

Changes: Latest screen shots for different instruments added.

Screenshot/s for the changes: N/A

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
N/A

@neel1998 neel1998 added the Documentation Non-code related documentation tasks label Aug 26, 2019
@neel1998 neel1998 self-assigned this Aug 26, 2019
@CloudyPadmal CloudyPadmal changed the title fix: readme images changed docs: readme images changed Aug 26, 2019
@neel1998
Copy link
Member Author

@CloudyPadmal @mariobehling don't merge this now. There some other changes as well that are to be made to readme. I will make them in this PR only. Thanks

@neel1998 neel1998 added the In Progress Developer is working on the problem label Aug 27, 2019
@neel1998 neel1998 force-pushed the robotic_arm_readme_image branch from 540b7e4 to 01f678b Compare August 28, 2019 06:41
@neel1998 neel1998 force-pushed the robotic_arm_readme_image branch from 01f678b to 6ccd47c Compare August 28, 2019 06:45
@neel1998
Copy link
Member Author

@CloudyPadmal @mariobehling I have updated the read me with latest screen shots. Have added local resource for play store and fdroid badges. Please review and merge. Thanks

@neel1998 neel1998 added Status: Review Required Requested reviews from peers and maintainers and removed In Progress Developer is working on the problem labels Aug 28, 2019
@mariobehling mariobehling merged commit 57a2e83 into fossasia:development Aug 28, 2019
@mariobehling
Copy link
Member

Please also add an updated screenshot of the robotic arm screen.

@neel1998
Copy link
Member Author

I have already updated robotic arm screen shot.

@CloudyPadmal CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Aug 28, 2019
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Non-code related documentation tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add robotic arm screenshot with actual values and examples instead of everything 0
3 participants