Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wave generator active even without pressing view button #1949

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

neel1998
Copy link
Member

Fixes #1928

Changes: Wave generator active even without pressing view button

Screenshot/s for the changes:
20190818_234846

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
wave.tar.gz

@neel1998 neel1998 added the Fix Solution to an existing issue in app label Aug 18, 2019
@neel1998 neel1998 requested a review from CloudyPadmal August 18, 2019 19:07
@neel1998 neel1998 self-assigned this Aug 18, 2019
@CloudyPadmal CloudyPadmal merged commit f623086 into fossasia:development Aug 19, 2019
@CloudyPadmal CloudyPadmal changed the title feat: Wave generator active even without pressing view button fix: Wave generator active even without pressing view button Aug 19, 2019
@neel1998 neel1998 deleted the wave_gen_active branch August 27, 2019 13:57
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wave generator not active unless view in pressed
2 participants