feat: new Wave Generator UI #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Aug 16, 2019
neel1998
force-pushed
the
new_wave_gen_ui
branch
from
3da8122 to
c9b93c8
Compare
neel1998
force-pushed
the
new_wave_gen_ui
branch
from
c9b93c8 to
7846c5e
Compare
neel1998
added
Enhancement
neel1998
force-pushed
the
new_wave_gen_ui
branch
from
7846c5e to
906596a
Compare
|
@CloudyPadmal please review |
CloudyPadmal
approved these changes
Aug 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1935
Changes: new Wave Generator UI
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
wave.zip
TODO for subsequesnt PRs
@mariobehling @CloudyPadmal since this PR is getting too large, I will make the above changes is subsequent PRs. For now wave generator is working totally fine. I have mmoved view and save buttons to to action bar.... Please review