fix: Actionbar added to Oscilloscope and Robotic Arm #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Aug 15, 2019
|
@CloudyPadmal sure... Sorry I forgot to squash in hurry... |
neel1998
force-pushed
the
actionbar_landscape
branch
2 times, most recently
from
c742939 to
7333612
Compare
|
@CloudyPadmal i think this can be merged |
adityastic
approved these changes
Aug 16, 2019
CloudyPadmal
requested changes
Aug 16, 2019
|
Test all the features and make sure they're working as intended. |
|
@CloudyPadmal sure I will test. That white space doesn't appear on my device. Maybe it's screen size issue... Will fix it. Thanks for the review |
neel1998
force-pushed
the
actionbar_landscape
branch
from
7333612 to
756975a
Compare
|
@CloudyPadmal i have set playback layout width to match_parent... please check if that white space still there. Also I was not able to reproduce the infinite loop you mentioned for looged data.. Can you please give me exact steps or a GIF. Thanks |
|
@CloudyPadmal please review |
CloudyPadmal
approved these changes
Aug 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1929 #1930
Changes: Actionbar added to Oscilloscope and Robotic Arm
Screenshot/s for the changes:
Oscilloscope main layout
Oscilloscope Playback
Robotic Arm
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
actionbar.zip
@CloudyPadmal @mariobehling I will add action bar to Logic Analyzer in separate PR... Since the implementation of LA is quite different (inflating a fragment in activity) i think I will have to come up with some hack or change the implementation. For now action bar works fine in oscilloscope and Robotic Arm. Thanks