Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update readme #1920

Merged
merged 1 commit into from
Aug 8, 2019
Merged

docs: update readme #1920

merged 1 commit into from
Aug 8, 2019

Conversation

CloudyPadmal
Copy link
Collaborator

@CloudyPadmal CloudyPadmal commented Aug 8, 2019 •
edited
Loading

Fixes #1919

Changes:

  • Added gas sensor to instrument list
  • Added badges for version and repo size
  • Fixed indentation errors

Screenshot/s for the changes:

Not available

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have requested reviews from other members

APK for testing:

Not available. Purpose of this PR is to have release draft tested in parallel.
Check readme from -> https://github.com/CloudyPadmal/pslab-android/tree/update-readme

@CloudyPadmal CloudyPadmal added the Documentation Non-code related documentation tasks label Aug 8, 2019
@CloudyPadmal CloudyPadmal self-assigned this Aug 8, 2019
neel1998
neel1998 approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@neel1998 neel1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@CloudyPadmal CloudyPadmal merged commit 45b561b into fossasia:development Aug 8, 2019
@CloudyPadmal CloudyPadmal deleted the update-readme branch August 8, 2019 11:47
@CloudyPadmal
Copy link
Collaborator Author

@neel1998 Thanks for the review.

makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
@CloudyPadmal @makoteq
docs: update readme (fossasia#1920)
6a4ac43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neel1998 neel1998 neel1998 approved these changes

@cweitat cweitat Awaiting requested review from cweitat

Assignees

@CloudyPadmal CloudyPadmal

Labels
Documentation Non-code related documentation tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update readme with Gas sensor
2 participants
@CloudyPadmal @neel1998