feat: interface for ESP wifi module added #1911
Conversation
|
Third time I'm seeing you closing and opening new PRs. This PR is related to #1892 |
app/build.gradle
Outdated
| @@ -139,4 +139,5 @@ dependencies { | |||
| exclude group: 'com.android.support', module: 'appcompat-v7' | |||
| exclude group: 'com.android.support', module: 'design' | |||
| } | |||
| implementation "com.squareup.okhttp3:okhttp:4.0.1" | |||
There was a problem hiding this comment.
Move where the other dependencies are and set version in config files.
|
I am sorry but while trying out the BFG tool ... I had accidentally removed png and XML files from many of my local branches.. if made a new commit using the previous branch....All the png and XML would be again added to the commit. That's why I had to open another PR from new branch. Sorry for the inconvenience. |
| AlertDialog.Builder dialogBuilder = new AlertDialog.Builder(MainActivity.this); | ||
| LayoutInflater inflater = MainActivity.this.getLayoutInflater(); | ||
| View dialogView = inflater.inflate(R.layout.bluetooth_wifi_dialog_layout, null); | ||
| dialogBuilder.setNegativeButton("Cancel", new DialogInterface.OnClickListener() { |
| if (espIPAddress.length() == 0) { | ||
| Toast.makeText(getContext(), getResources().getString(R.string.incorrect_IP_address_message), Toast.LENGTH_SHORT).show(); | ||
| } else { | ||
| espConnectProgressBar.setVisibility(View.VISIBLE); |
| params.width = ViewGroup.LayoutParams.MATCH_PARENT; | ||
| getDialog().getWindow().setAttributes((android.view.WindowManager.LayoutParams) params); | ||
| } | ||
| private class ESPTask extends AsyncTask<Void, Void, String> { |
There was a problem hiding this comment.
Reformat the whole code to add proper indents and spaces. Should be quiet obvious by now.
app/src/main/res/values/strings.xml
Outdated
| @@ -18,12 +18,16 @@ | |||
| <string name="pslab_pinlayout_front">Pin Layout Front</string> | |||
| <string name="pslab_pinlayout_back">Pin Layout Back</string> | |||
| <string name="bluetooth_connect_menu">Bluetooth Connection</string> | |||
| <string name="bluetooth_scan_dialog">USB device not found. Do you want to scan for Bluetooth Connection?</string> | |||
|
|
|||
| <string name="bluetooth_wifi_scan_dialog">USB device not found. Do you want to scan for Bluetooth or Wifi Connection?</string> | |||
There was a problem hiding this comment.
Connection -> connection
app/src/main/res/values/strings.xml
Outdated
| <string name="bluetooth_scan_dialog">USB device not found. Do you want to scan for Bluetooth Connection?</string> | ||
|
|
||
| <string name="bluetooth_wifi_scan_dialog">USB device not found. Do you want to scan for Bluetooth or Wifi Connection?</string> | ||
| <string name="bluetooth">Bluetooh</string> |
Thing is, when you're making new PRs closing older ones, whole conversations are gone. All the discussions, changes requested; just gone. Whatever the issue you're having with your local branch, fix it before making any more PRs. |
I totally understand your point. And I was using the tool for the first time so made such mistake. Again really sorry for this, won't happen again. |
CloudyPadmal
added
the
Status: Review Required
CloudyPadmal
added
Feature
CloudyPadmal
changed the title
Fixes #1891
Changes: User can connect to pslab using wifi
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
esp.zip
@CloudyPadmal the interface seems nice, Once the ESP server is implemented we can add further communication protocols.