feat: logic analyzer logging/ playback added #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neel1998
changed the title
CloudyPadmal
reviewed
Aug 4, 2019
|
The mode will be set as whatever user has selected while user records the data... According to that spinner while playing back will be set. A separate LogicAnalyzerData object is created for each channel |
CloudyPadmal
approved these changes
Aug 4, 2019
CloudyPadmal
changed the title
makoteq
pushed a commit
to makoteq/pslab-android
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1909
Changes: Logging for Logic Analyzer
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
la_logging.zip
@CloudyPadmal since unlike oscilloscope waves in LA are not continuously moving, I think there is no need to add continuous logging here .. it will add unnecessary complexity and redundant data.