Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logic analyzer bug fixed #1908

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

neel1998
Copy link
Member

@neel1998 neel1998 commented Aug 2, 2019

Fixes #1825

Changes: Logic analyzer giving proper output

Screenshot/s for the changes:

**before

**after

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
la.zip

Just a few lines change does make a difference 😂

@CloudyPadmal CloudyPadmal merged commit e09392b into fossasia:development Aug 2, 2019
@CloudyPadmal CloudyPadmal added the Bug Unexpected problem or unintended behavior in app label Aug 8, 2019
@CloudyPadmal CloudyPadmal changed the title logic analyzer bug fixed fix: logic analyzer bug fixed Aug 8, 2019
@CloudyPadmal CloudyPadmal added Fix Solution to an existing issue in app and removed Bug Unexpected problem or unintended behavior in app labels Aug 15, 2019
@neel1998 neel1998 deleted the logic_analyzer2 branch August 27, 2019 14:00
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic Analyser Not working as expected
2 participants