chore(deps): Bump gradle from 3.5.0 to 3.5.2 #2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rajchowdhury420 Please read |
|
Sir but I saw similar small fixes to be merged in FossAsia repos ! Can u
explain
…On Wed, Nov 6, 2019, 14:19 Suneet Srivastava ***@***.***> wrote:
@Rajchowdhury420 <https://github.com/Rajchowdhury420> Please read
https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&cad=rja&uact=8&ved=2ahUKEwjh--n2mdXlAhWLA3IKHQ2qC1AQFjAAegQIABAB&url=https%3A%2F%2Fblog.fossasia.org%2Fopen-source-developer-guide-and-best-practices-at-fossasia%2F&usg=AOvVaw1szzuiHMmsqCtg1VGocPHu
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2905?email_source=notifications&email_token=AHLBGYX6CKIXGYM7XKYMTXLQSKAIZA5CNFSM4JJLZSS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDFYGNA#issuecomment-550208308>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHLBGYTVYEQRD633Y2ZWDVDQSKAIZANCNFSM4JJLZSSQ>
.
|
|
@Rajchowdhury420 Yes valid pull request are always merged, do give read on the above blog You need to open an issue and send a PR tagged to that issue also, your branch is out of date - please check https://stackoverflow.com/questions/53712930/how-to-fix-this-in-git-this-branch-is-out-of-date-with-the-base-branch |
|
M really sorry !
…On Wed, Nov 6, 2019, 20:18 Suneet Srivastava ***@***.***> wrote:
@Rajchowdhury420 <https://github.com/Rajchowdhury420> Yes valid pull
request are always merged, do give read on the above blog
You need to open an issue and send a PR tagged to that issue
also, your branch is out of date - please check
https://stackoverflow.com/questions/53712930/how-to-fix-this-in-git-this-branch-is-out-of-date-with-the-base-branch
Also did
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2905?email_source=notifications&email_token=AHLBGYTGWN7JHNNXSWMKKJLQSLKNRA5CNFSM4JJLZSS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGZDRI#issuecomment-550343109>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHLBGYTKLXZFZ7ACQ3BWUCTQSLKNRANCNFSM4JJLZSSQ>
.
|
|
@iamareebjamal No need to be sorry, we are always here to learn. Welcome to the community and the project. Do join the channels and get stared! |
|
Thank you sir , it just I m a bit new to development I m just 17
…On Wed, Nov 6, 2019, 20:22 Suneet Srivastava ***@***.***> wrote:
@iamareebjamal <https://github.com/iamareebjamal> No need to be sorry, we
are always here to learn. Welcome to the community and the project. Do join
the channels and get stared!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2905?email_source=notifications&email_token=AHLBGYR24VOH2TYVKAPNYULQSLK2TA5CNFSM4JJLZSS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGZQIQ#issuecomment-550344738>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHLBGYTSDFKMABXLC2MIRHTQSLK2TANCNFSM4JJLZSSQ>
.
|
|
@Rajchowdhury420 - |
|
Okay
…On Wed, Nov 6, 2019, 20:40 Suneet Srivastava ***@***.***> wrote:
@Rajchowdhury420 <https://github.com/Rajchowdhury420> -
You need to open an issue also.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2905?email_source=notifications&email_token=AHLBGYW3WPV4O3PEWD6DTZ3QSLM4RA5CNFSM4JJLZSS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDG3P5Y#issuecomment-550352887>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHLBGYUZC2636BAWZOASCRDQSLM4RANCNFSM4JJLZSSQ>
.
|
|
Please check it now |
codedsun
approved these changes
Nov 7, 2019
iamareebjamal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2906
Changes: Updated build.gradle file , Bumped the Gradle version from 3.5.0 to 3.5.2
Screenshots of the change: