fix: crash on orientation change while crop

[codedsun]

Fixed #2318

Changes: was getting empty text in on saved instance state, handled that

Screenshots of the change:

[codedsun]

@iamareebjamal Check this

[codedsun]

@iamareebjamal Please review

[iamareebjamal]

Peer review

[codedsun]

@iamareebjamal means?

[iamareebjamal]

Get PR approved by peers first

[codedsun]

@iamareebjamal None of them is available in this project except you.. Okay will tag

@yashk2000 Please review

He's unavailable due to exams I think

[yashk2000]

@iamareebjamal None of them is available in this project except you.. Okay will tag

@yashk2000 Please review

He's unavailable due to exams I think

I'll be getting a short break tomorrow. I'll test it then. Sorry for the inconvenience.

[codedsun]

@yashk2000 Please check!

[codedsun]

@yashk2000 Please check

[codedsun]

@yashk2000 Check

[codedsun]

@yashk2000 Inputs please

[yashk2000]

Seems fine. Could you please upload a gif?

[codedsun]

@yashk2000 Doing it.

[yashk2000]

If you change the crop settings in one mode, rotate the device and change the settings again and try to save the picture it works?

[codedsun]

Please detail in the steps

…

On Sun, Nov 3, 2019, 6:24 PM Yash Khare ***@***.***> wrote: If you change the crop settings in one mode, rotate the device and change the settings again and try to save the picture it works? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2901?email_source=notifications&email_token=AEYZISDBUQ35LPPNFZ2CCDDQR3CYBA5CNFSM4JG7FUOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5R4UI#issuecomment-549133905>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEYZISDZIHBY2PL3M4SEI53QR3CYBANCNFSM4JG7FUOA> .

[yashk2000]

1. Enter the crop mode.
2. Rotate the device.
3. Change the crop settings to anything other than 1:1. Change the default crop square that appears.
4. Rotate the device again.
5. Check if changes are retained and saved on clicking save.

[codedsun]

@yashk2000 They are retained but the editImageActivity has bugs which causes of loading of image and setting the fragments again. So the first time when the configuration change occurs,

1. Activity is recreated in the activity get data function is called which runs an aysnc task of loading the image, meanwhile the Crop fragment sets all the data in the fragment

Now after the result of the loadImage(get Data function), the fragments are created again. Hence the changes are lost

[yashk2000]

Ok. You can open a new issue for the other problem. That can be fixed in a separate pr.