feat: corrects flow of sd card permission #2898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamareebjamal Check this |
iamareebjamal
requested changes
Oct 20, 2019
codedsun
force-pushed
the
permissions
branch
2 times, most recently
from
2180888 to
d18f9a5
Compare
codedsun
changed the title
| } | ||
|
|
||
| public static boolean shouldShowPermissionRationale( | ||
| Object o, int permissionId, String permission) { |
There was a problem hiding this comment.
Why is this receiving object?
There was a problem hiding this comment.
Has always been receiving object, will change it.
| public static void requestPermissions( | ||
| Activity activity, int permissionId, String... permissions) { | ||
| ActivityCompat.requestPermissions(activity, permissions, permissionId); | ||
| } |
There was a problem hiding this comment.
This method is useless. Remove this method
| } | ||
|
|
||
| public static boolean shouldShowPermissionRationale(Activity activity, String permission) { | ||
| return ActivityCompat.shouldShowRequestPermissionRationale(activity, permission); |
|
@iamareebjamal Check it now |
|
@iamareebjamal Please check now |
|
I'm travelling. In train RN |
|
@iamareebjamal Please xheck this! |
|
@iamareebjamal please process |
iamareebjamal
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:
removes unnecessary permission from manifest andcorrects flow of sd card permissionFixed #2897
Changes: Removes unnecessary permission from manifest , flow of sd card permission handled
Screenshots of the change: