fix: Replace snackbars with snackbarshandler #2855
Conversation
|
@adityastic please review. |
|
Why? |
|
We have a separate class which we use for handling snackbars across the app, SnackbarHandler. Some of the snackbars being used currently were just made using snackbar.make, instead of the Handler class for snackbars. So I converted those to SnackbarHandler. |
|
What advantage does SnackbarHandler have? |
|
@iamareebjamal it was created to have a common class to create all kinds of snackbars except those with actions. We use it to create snackbars with different bottom margins. So all these functions we created in this common class, |
| .show(); | ||
| getString(R.string.Cloudrail_License_key), | ||
| Snackbar.LENGTH_SHORT); | ||
| snackbar.show(); |
There was a problem hiding this comment.
This is ridiculous. Why calling show 2 times. It should only be called once
There was a problem hiding this comment.
The earlier .show is SnackBarHandler.show(). This creates a snackbar and returns it. Then to show it, we use the second .show().
There was a problem hiding this comment.
Then it should not be called show. It should be create or make
There was a problem hiding this comment.
Ok. I'll do that and update the pr.
| public void showError() { | ||
| Snackbar snackbar = SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in)); | ||
| Snackbar snackbar = SnackBarHandler.create(coordinatorLayout, getString(no_account_signed_in)); | ||
| snackbar.show(); |
There was a problem hiding this comment.
No need to save in a variable. Directly call show
|
@iamareebjamal please merge. |
2 participants
Fixed #2593
Changes: Replace snackbars with snackbarshandler