fix: Added alert if user clicks tick button in stickers section without adding any stickers. #2772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adityastic @iamareebjamal @abishekvashok @mariobehling please review. |
|
@abishekvashok @mariobehling which is better:
|
|
2nd one! |
|
@abishekvashok sure 👍 |
…ing any stickers.
|
@abishekvashok please review. I have updated the icon. |
yashk2000
changed the title
abishekvashok
approved these changes
Jun 14, 2019
|
@abishekvashok could you please squash it here 😅? If I squash, it might lead to a few unexpected changes over here which I'll have to revert again. |
pull bot
pushed a commit
to sahilsaha7773/phimpme-android
that referenced
this pull request
Jul 18, 2019
…#2772) Added alert if user clicks tick button in stickers ection without adding any stickers. Fixes fossasia#2656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2656
Changes: If user presses tick button in stickers section without using any sticker, an alert is shown.
I have not used
button.setEnabled(false);because it will make the user confused as to why the tick button is not working.Screenshots of the change: