Skip to content

Conversation

@yashk2000
Copy link
Member

Fixed #2763

Changes: Changes compile to implementation, debugCompile to debugImplementation and other related changes. Also, updated versions of dependencies used.

@mariobehling
Copy link
Member

Travis is failing. Please fix.

@yashk2000
Copy link
Member Author

Yes sir. I am working on fixing it.

@yashk2000
Copy link
Member Author

@iamareebjamal @abishekvashok I am not able to resolve this error:

Dependencies using groupId com.android.support and androidx.* can not be combined but found IdeMavenCoordinates{myGroupId='com.android.support', myArtifactId='recyclerview-v7', myVersion='28.0.0', myPacking='aar', myClassifier='null'} and IdeMavenCoordinates{myGroupId='androidx.drawerlayout', myArtifactId='drawerlayout', myVersion='1.0.0', myPacking='aar', myClassifier='null'} incompatible dependencies less... (Ctrl+F1) Inspection info:There are some combinations of libraries, or tools and libraries, that are incompatible, or can lead to bugs. One such incompatibility is compiling with a version of the Android support libraries that is not the latest version (or in particular, a version lower than your targetSdkVersion).

Issue id: GradleCompatible

Could you please help with this? As far as I know, we are not using android.x in the app yet.

@iamareebjamal
Copy link
Member

You are using androidx somewhere in some transitive dependency

@yashk2000
Copy link
Member Author

@iamareebjamal how do I find the dependency in which androidx has been used?

@iamareebjamal
Copy link
Member

./gradlew app:dependencies

@yashk2000 yashk2000 changed the title chore: Removed obsolete configurations and updated versions of dependencies. [WIP] chore: Removed obsolete configurations and updated versions of dependencies. Jun 12, 2019
@yashk2000
Copy link
Member Author

@iamareebjamal did that. I was still unable to find androidx anywhere.

@iamareebjamal
Copy link
Member

That's impossible.

@yashk2000
Copy link
Member Author

@iamareebjamal apologies. I found out that androidx is being used. I went through all the dependencies manually this time. Earlier I was using the search feature of the terminal itself, which may be cause me to skip androidx.

@yashk2000
Copy link
Member Author

@iamareebjamal how do I fix this: error: package android.test does not exist

ApplicationTestCase was deprecated in API Level 24.

@iamareebjamal
Copy link
Member

Update the tests

@yashk2000
Copy link
Member Author

@iamareebjamal how do I replace the ApplicationTestCase?

@yashk2000 yashk2000 changed the title [WIP] chore: Removed obsolete configurations and updated versions of dependencies. chore: Removed obsolete configurations and updated versions of dependencies. Jun 17, 2019
@yashk2000
Copy link
Member Author

@iamareebjamal iamareebjamal merged commit b3fd111 into fossasia:development Jun 18, 2019
pull bot pushed a commit to sahilsaha7773/phimpme-android that referenced this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change compile to implementation and update dependencies.

4 participants