Skip to content

Conversation

@yashk2000
Copy link
Member

Changes: Made changes in the travis.yml file. Now instead of 3 parallel jobs, 2 jobs are run in series. Time taken is approximately the same.

@yashk2000
Copy link
Member Author

@iamareebjamal @abishekvashok please review.

@iamareebjamal
Copy link
Member

Also, we have 3 tests in integration tests for Android. That's insanely low amount of tests to waste 20 minutes of build time. There are also explicit sleeps of 10 seconds or so.

Some of the tests are so basic that they test that if I click on a tab, it goes to that tab. This is tested by Android framework team, why are we testing it? We should check our own logic.

Please find last 5 PRs in which these tests failed so that we can evaluate their importance. Then, we'll either remove them or improve them by removing sleep statements and converting them to RoboElectric tests so that they can run on JVM without AVD

@yashk2000
Copy link
Member Author

#2571
#2524
#2426
#2414
#2372

@iamareebjamal last 5 prs in which tests failed.

@yashk2000
Copy link
Member Author

@iamareebjamal should I make any more changes to the travis script?

@iamareebjamal
Copy link
Member

I'll analyse these PRs and open an issue if needed

@iamareebjamal iamareebjamal merged commit 8e99053 into fossasia:development May 29, 2019
@iamareebjamal
Copy link
Member

@yashk2000 We need PRs where only COMPONENT=CONNECTED_TEST is failing. All these PRs have build failing. We need to see how important connected tests are for the project

@yashk2000
Copy link
Member Author

@iamareebjamal ok. I'll search for prs in which CONNECTED_TEST is failing.

pull bot pushed a commit to sahilsaha7773/phimpme-android that referenced this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants