Skip to content

Conversation

@yashk2000
Copy link
Member

@yashk2000 yashk2000 commented May 24, 2019

Fixes #2118
Changes: Initial attempt for the auto release process.

@yashk2000
Copy link
Member Author

@iamareebjamal @abishekvashok @sauravvishal8797 please review and tell what changes have to be made.

Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that I prefer a blank line eof

@iamareebjamal
Copy link
Member

Not complete yet. Will make some changes.

@yashk2000
Copy link
Member Author

yashk2000 commented May 25, 2019

@iamareebjamal please tell me what changes to make.
Changes to be made which I did not do yet:

  • Edit the travis.yml to run this script if build is successful.
  • Once this script works, delete the existing scripts as they will become redundant.

@iamareebjamal
Copy link
Member

Add prep-key.sh and this in the travis build. I'll review and take it from there

@yashk2000
Copy link
Member Author

@iamareebjamal done.

@iamareebjamal
Copy link
Member

Last command (fastlane) is wrong

@yashk2000
Copy link
Member Author

@iamareebjamal is it correct now?

@yashk2000 yashk2000 changed the title [WIP] feat: Automatic release process feat: Automatic release process May 26, 2019
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong command

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal could you please tell me what's wrong with the command here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to move this block before than mv commands

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@iamareebjamal iamareebjamal merged commit d1fc22f into fossasia:development May 27, 2019
pull bot pushed a commit to sahilsaha7773/phimpme-android that referenced this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automated deployment issue.

3 participants