-
Notifications
You must be signed in to change notification settings - Fork 914
feat: Automatic release process #2745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@iamareebjamal @abishekvashok @sauravvishal8797 please review and tell what changes have to be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just that I prefer a blank line eof
|
Not complete yet. Will make some changes. |
|
@iamareebjamal please tell me what changes to make.
|
|
Add prep-key.sh and this in the travis build. I'll review and take it from there |
|
@iamareebjamal done. |
|
Last command (fastlane) is wrong |
|
@iamareebjamal is it correct now? |
scripts/update-apk.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamareebjamal could you please tell me what's wrong with the command here?
scripts/update-apk.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to move this block before than mv commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
Fixes #2118
Changes: Initial attempt for the auto release process.