Fix for issue#2457: Fixed the view which was not looking good. #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i would suggest that you remove the white lines which are differentiating between the accounts. it does not look good with dark and dark amoled theme. |
|
@kk63852 I tried doing it such that the gap would be minimum. I found no other way to remove that bar which was popping up without adding any padding. |
|
the accounts are setup in a recycler view. that is why it seems difficult to remove the white lines. |
krishna-k03
approved these changes
Jan 28, 2019
naman653
approved these changes
Jan 30, 2019
abishekvashok
approved these changes
Jan 31, 2019
|
Thanks :) |
pull bot
pushed a commit
to sahilsaha7773/phimpme-android
that referenced
this pull request
Jul 18, 2019
Fix for issue#2457: Fixed the view which was not looking good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2457
Changes: The bar which was showing up unnecessarily has been removed.
Screenshots of the change: