Fix #2442 Made navigation drawer visible onResume where ever required. #2443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2000
approved these changes
Jan 22, 2019
abishekvashok
approved these changes
Jan 23, 2019
GOVINDDIXIT
approved these changes
Feb 1, 2019
abishekvashok
suggested changes
Feb 2, 2019
| if (all_photos && !fav_photos) { | ||
| new PrepareAllPhotos(activityContext).execute(); | ||
| } | ||
| if (!all_photos && fav_photos) { |
There was a problem hiding this comment.
Why was this condition removed?
There was a problem hiding this comment.
None of the conditions were removed, just replaced 2nd if statement with an else if statement and moved the block of code one line up.
abishekvashok
approved these changes
Feb 2, 2019
|
Thanks |
pull bot
pushed a commit
to sahilsaha7773/phimpme-android
that referenced
this pull request
Jul 18, 2019
Fix fossasia#2442 Made navigation drawer visible onResume where ever required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2442 Made navigation drawer visible onResume where ever required.
Changes: LFMainActivity.java
Screenshots of the change: