Fix #2399 - Remove redundant drawable ic_search_black_24dp #2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abishekvashok
suggested changes
Jan 17, 2019
| <item name="closeIcon">@drawable/ic_close_black_24dp</item> | ||
| <!-- Search button icon --> | ||
| <item name="searchIcon">@drawable/ic_search_black_24dp</item> | ||
| <item name="searchIcon">@drawable/ic_search_white_24dp</item> |
There was a problem hiding this comment.
Err why did you remove it
There was a problem hiding this comment.
@abishekvashok, sorry but you are addressing the drawable file or styles.xml
There was a problem hiding this comment.
@abishekvashok, if the drawable file ic_search_black_24dp is removed then referencing it in styles.xml will produce error. And drawable file ic_search_black_24dp must be deleted as it is currently not used anywhere in the project.
There was a problem hiding this comment.
The drawable was being used. You removed it's use and deleted it. See the entire diff
There was a problem hiding this comment.
@abishekvashok, I had to remove the use of the drawable file because of this
So I had to create ic_search_white_24dp
abishekvashok
approved these changes
Jan 20, 2019
angmas1
added a commit
to angmas1/phimpme-android
that referenced
this pull request
Jan 20, 2019
* Merging development into master (fossasia#2156) * Fix fossasia#2151-On back press operation issue resolved. (fossasia#2152) * Fix fossasia#2154-Fixes issues for favourite section, security feature and SingleMediaActivity. (fossasia#2155) * chore: Accept license agreement for SDK 26 to travis ci (fossasia#2418) (fossasia#2419) * Fix fossasia#2410 Albums get selected properly. (fossasia#2415) * Fix fossasia#1810 LongPress works correctly for selecting multiple photos in … (fossasia#2409) * Fix fossasia#1810 LongPress works correctly for selecting multiple photos in FavouritesActivity. * Corrected else brackets. * Corrected(Moved Up). * Fix fossasia#2399 - Remove redundant drawable ic_search_black_24dp (fossasia#2400) * Replaced Toasts with SnackBars. (fossasia#2391) * Readme improvement (fossasia#2327) * readme_ * readme_improved
pull bot
pushed a commit
to sahilsaha7773/phimpme-android
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2399
Changes: Unused drawable file ic_search_black_24dp.xml is deleted.