FIXED #2162 All GIF files are saved properly #2163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abishekvashok
suggested changes
Sep 12, 2018
| } | ||
| byte[] bytes = createGIFFromImages(bitmaps); | ||
| File file = new File(Environment.getExternalStorageDirectory() + "/" + "Phimpme_gifs"); | ||
| DateFormat dateFormat = new SimpleDateFormat("dMMMyyyy_HHmmss"); |
There was a problem hiding this comment.
It should have been ddMMYY_HHmm
We don't want seconds :P
abishekvashok
suggested changes
Sep 12, 2018
| } | ||
| byte[] bytes = createGIFFromImages(bitmaps); | ||
| File file = new File(Environment.getExternalStorageDirectory() + "/" + "Phimpme_gifs"); | ||
| DateFormat dateFormat = new SimpleDateFormat("dMMyy_HHmm"); |
|
I am really sorry for the mistakes ,this is my first PR,I will make sure it never happens again in the future. |
abishekvashok
approved these changes
Sep 29, 2018
|
Thank you |
pull bot
pushed a commit
to sahilsaha7773/phimpme-android
that referenced
this pull request
Jul 18, 2019
FIXED fossasia#2162 All GIF files are saved properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2162
Changes: The GIF files were created with the same filename (GIF.gif) due to which the newly created gif was overwritten to the old gif and only one file was saved at a time ,so I added date and time to the gif filename so that the new files don't overwrite the previous ones.