Event model: Add info about presence of sessions,speakers #5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #5560 +/- ##
===============================================
+ Coverage 63.25% 63.26% +<.01%
===============================================
Files 265 265
Lines 12726 12734 +8
===============================================
+ Hits 8050 8056 +6
- Misses 4676 4678 +2
Continue to review full report at Codecov.
|
|
@CosmicCoder96 This will slow down the list queries by a lot. This should be handled by a separate relationship to event |
mrsaicharan1
pushed a commit
to mrsaicharan1/open-event-server
that referenced
this pull request
Jan 30, 2019
mrsaicharan1
added a commit
to mrsaicharan1/open-event-server
that referenced
this pull request
Jan 30, 2019
Event model: Add info about presence of sessions,speakers (fossasia#5560) Changed from long abstract to short Reverted attendees for Travis build
|
As mentioned, this slowed down queries by large amount |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5529
Short description of what this resolves:
Eliminates the need to fetch all sessions and speakers of an event just to check if they exist.
Changes proposed in this pull request:
has_sessionsto the event modelhas_speakersto the event model