Skip to content

chore: Update APK naming convention #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2019
Merged

chore: Update APK naming convention #1771

merged 2 commits into from
Jul 4, 2019

Conversation

@ShridharGoel
Copy link
Member

Fixes #1764

@auto-label auto-label bot added the chore label Jul 2, 2019
@ShridharGoel ShridharGoel changed the title chore: Update APK generation and naming convention chore: Update APK generation and follow naming convention Jul 2, 2019
@iamareebjamal
Copy link
Member

Wait till #1770

@ShridharGoel
Copy link
Member Author

@iamareebjamal Since #1770 is merged, any changes required in this?

liveHarshit
liveHarshit reviewed Jul 2, 2019
View reviewed changes
Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open-event-organizer-android/scripts/update-apk.sh

Line 67 in fe47981

fastlane supply --aab eventyay-organizer-master-app.aab --track alpha --json_key ../scripts/fastlane.json --package_name $PACKAGE_NAME

I think eventyay-organizer-master-app.aab should replace with eventyay-organizer-master.aab.

iamareebjamal
iamareebjamal reviewed Jul 2, 2019
View reviewed changes
@ShridharGoel
Copy link
Member Author

open-event-organizer-android/scripts/update-apk.sh

Line 67 in fe47981

fastlane supply --aab eventyay-organizer-master-app.aab --track alpha --json_key ../scripts/fastlane.json --package_name $PACKAGE_NAME

I think eventyay-organizer-master-app.aab should replace with eventyay-organizer-master.aab.

@iamareebjamal Please confirm.

@iamareebjamal
Copy link
Member

yes

@ShridharGoel
Copy link
Member Author

Updated.

@ShridharGoel ShridharGoel changed the title chore: Update APK generation and follow naming convention chore: Update APK naming convention Jul 2, 2019
@iamareebjamal iamareebjamal merged commit d42290f into fossasia:development Jul 4, 2019
@ShridharGoel ShridharGoel deleted the update-apk-naming branch July 5, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+1 more reviewer

@liveHarshit liveHarshit liveHarshit left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update APK generation and follow name conventions

3 participants

@ShridharGoel @iamareebjamal @liveHarshit