-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Security update: fixes several bugs #9196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-UAPARSERJS-3244450
[Snyk] Security upgrade ua-parser-js from 1.0.2 to 1.0.33
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request updates the base Docker images to use specific, more secure versions and updates the Class diagram for ua-parser-js updateclassDiagram
class UAParser {
+ version: string
+ getResult(): object
+ getBrowser(): object
+ getDevice(): object
+ getOS(): object
+ getEngine(): object
}
note for UAParser "Updated to version 1.0.33"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
We don't accept pull requests from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @savaliyabhargav - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's great to see the node base image being updated, but can we also update the other dependencies?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Fixes #
Short description of what this resolves:
Changes proposed in this pull request:
Checklist
development
branch.Summary by Sourcery
Updates the base Docker image to use node:14.19.1-bullseye-slim and updates the ua-parser-js dependency to version 1.0.33.
Enhancements: