Skip to content

Security update: fixes several bugs #9196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

savaliyabhargav
Copy link

@savaliyabhargav savaliyabhargav commented Mar 20, 2025

Fixes #

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Summary by Sourcery

Updates the base Docker image to use node:14.19.1-bullseye-slim and updates the ua-parser-js dependency to version 1.0.33.

Enhancements:

  • Updates the ua-parser-js dependency to version 1.0.33 to address security concerns and improve performance.
  • Updates the base Docker image to node:14.19.1-bullseye-slim to address security vulnerabilities.

savaliyabhargav and others added 3 commits April 13, 2022 09:12
[Snyk] Security upgrade ua-parser-js from 1.0.2 to 1.0.33
Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-event-frontend ❌ Failed (Inspect) Mar 20, 2025 6:06am

Copy link

sourcery-ai bot commented Mar 20, 2025

Reviewer's Guide by Sourcery

This pull request updates the base Docker images to use specific, more secure versions and updates the ua-parser-js dependency to the latest version. The yarn lock file was also updated to reflect these changes.

Class diagram for ua-parser-js update

classDiagram
    class UAParser {
      + version: string
      + getResult(): object
      + getBrowser(): object
      + getDevice(): object
      + getOS(): object
      + getEngine(): object
    }
    note for UAParser "Updated to version 1.0.33"
Loading

File-Level Changes

Change Details Files
Updated the base Docker images to use specific, more secure versions.
  • Changed the base image for the builder stage from node:14-alpine3.11 to node:14.19.1-bullseye-slim.
  • Changed the base image for the final stage from node:14-alpine3.11 to node:14.19.1-bullseye-slim.
Dockerfile
Updated the ua-parser-js dependency to the latest version.
  • Updated ua-parser-js from version 1.0.2 to 1.0.33.
package.json
Updated the yarn lock file to reflect the dependency changes.
  • The yarn lock file was updated to reflect the new version of ua-parser-js and the updated base docker images.
yarn.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

We don't accept pull requests from development or testing branch. Please send a pull request from some other branch. Thank You!

@github-actions github-actions bot closed this Mar 20, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @savaliyabhargav - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It's great to see the node base image being updated, but can we also update the other dependencies?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants