Skip to content

fix: preselect ticket buyer as holder for existing buyers #6784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 15, 2021

Conversation

Tlazypanda
Copy link
Contributor

Fixes #5851

Short description of what this resolves:

Preselect ticket buyer as holder for exisiting buyers i.e except new buyers for other cases ticket buyer is preselected as ticket holder

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Feb 21, 2021
@vercel
Copy link

vercel bot commented Feb 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/Cd9pQ4LrBXnohJYLyEu1xdDVkQj6
✅ Preview: https://open-event-frontend-git-fork-tlazypanda-preselectbuyer-eventyay.vercel.app

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #6784 (0693367) into development (062716d) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6784      +/-   ##
===============================================
- Coverage        20.98%   20.93%   -0.06%     
===============================================
  Files              574      574              
  Lines             6499     6501       +2     
  Branches           149      149              
===============================================
- Hits              1364     1361       -3     
- Misses            5108     5113       +5     
  Partials            27       27              
Impacted Files Coverage Δ
app/components/forms/orders/order-form.js 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062716d...0693367. Read the comment docs.

@Tlazypanda
Copy link
Contributor Author

@iamareebjamal can you please review? 😅

@iamareebjamal
Copy link
Member

If last name is null?

@mariobehling mariobehling changed the title fix: preselect ticket buyer as holder for exisiting buyers fix: preselect ticket buyer as holder for existing buyers Feb 22, 2021
@Tlazypanda
Copy link
Contributor Author

@iamareebjamal is this okay now?

@maze-runnar
Copy link
Contributor

It's working fine, but I have a doubt regarding here -
Screenshot from 2021-05-14 22-09-37

ticket holder is same person as ticket buyer, this should be checked by default, or should be removed.

@MeghalBisht
Copy link
Member

ticket holder is same person as ticket buyer, this should be checked by default, or should be removed.

Checked by default for the first ticket

@maze-runnar
Copy link
Contributor

ticket holder is same person as ticket buyer, this should be checked by default, or should be removed.

Checked by default for the first ticket

ok, please add this.

@MeghalBisht
Copy link
Member

@maze-runnar Please check it works for me now.

Co-authored-by: Sundaram Dubey <56407566+maze-runnar@users.noreply.github.com>
@MeghalBisht MeghalBisht merged commit 06e05f9 into fossasia:development May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preselect "Ticket holder" same as "Ticket Buyer
5 participants