Skip to content

Fix: Order success Change the download tickets to all tickets button #5860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Raunaksingh100
Copy link
Member

@Raunaksingh100 Raunaksingh100 commented Dec 2, 2020

Fixes #5852

Short description of what this resolves:

Change the icon as well as fixed the button name see in thee screenshot for the better understanding.

scrennshot

n

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Dec 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/p5qu5iacm
✅ Preview: https://open-event-frontend-git-patch-6.eventyay.now.sh

@Raunaksingh100 Raunaksingh100 changed the title Fix: Fix: Order success Ch age the download tickets to all tickets button Dec 2, 2020
@Raunaksingh100 Raunaksingh100 changed the title Fix: Order success Ch age the download tickets to all tickets button Fix: Order success Change the download tickets to all tickets button Dec 2, 2020
@Raunaksingh100
Copy link
Member Author

@mariobehling i perfectly fixed the issue

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #5860 (ca88a8e) into development (1e5239d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5860   +/-   ##
============================================
  Coverage        23.46%   23.46%           
============================================
  Files              512      512           
  Lines             5460     5460           
  Branches            63       63           
============================================
  Hits              1281     1281           
  Misses            4163     4163           
  Partials            16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e5239d...ca88a8e. Read the comment docs.

@mariobehling
Copy link
Member

Please keep the position and width of the buttons as before.

@Raunaksingh100
Copy link
Member Author

Raunaksingh100 commented Dec 2, 2020

Please keep the position and width of the buttons as before.

@mariobehling we cannot set size of button it automatically increase or decrees by the content.

@@ -84,7 +84,7 @@ body.dimmable.undetached.dimmed {
}

.space-between {
justify-content: space-between;
justify-content: space-evenly;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't just change the class content without impacting everywhere the class is used

@iamareebjamal
Copy link
Member

Fixed already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Success Page: Change "Download Tickets" to "All Tickets" and use download icon
5 participants