Skip to content

fix: Reimplement session route to not reload page on filter #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion app/controllers/public/sessions.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import classic from 'ember-classic-decorator';
import { computed } from '@ember/object';
import { action, computed } from '@ember/object';
import Controller from '@ember/controller';
import moment from 'moment';
import $ from 'jquery';

@classic
export default class SessionsController extends Controller {
Expand All @@ -11,6 +12,21 @@ export default class SessionsController extends Controller {
isTrackVisible = false;
timezone = null;

constructor(...args) {
super(...args);

this.addObserver('model.session', this, 'sessionChanged');
}

@action
sessionChanged() {
if (this.model.isFiltering) {
$('html,body').animate({
scrollTop: $('#session-heading').offset()?.top
});
}
}

@computed('model.event.startsAt', 'model.event.endsAt', 'timezone')
get allDates() {
const arr = [];
Expand Down
5 changes: 4 additions & 1 deletion app/routes/public/sessions.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ export default class SessionsRoute extends Route {
});
}

const isFiltering = params.room || params.track || params.date;

return {
event : eventDetails,
session : await this.infinity.model('sessions', {
Expand All @@ -98,7 +100,8 @@ export default class SessionsRoute extends Route {
perPageParam : 'page[size]',
pageParam : 'page[number]',
store : eventDetails
})
}),
isFiltering
};
}
}
2 changes: 1 addition & 1 deletion app/templates/public/sessions.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<h1 class="ui header">{{t 'Sessions'}}</h1>
<h1 class="ui header" id="session-heading">{{t 'Sessions'}}</h1>

<div class="d-flex wrap">
<LinkTo @route="public.sessions" @models={{array this.model.event.id}} @query={{hash date=null}} class="ui button mb-2">{{t 'All'}}</LinkTo>
Expand Down