-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: Registration deadline not working #5695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Registration deadline not working #5695
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/me28lff1p |
|
Codecov Report
@@ Coverage Diff @@
## development #5695 +/- ##
===============================================
+ Coverage 23.72% 23.77% +0.04%
===============================================
Files 509 509
Lines 5411 5413 +2
Branches 59 59
===============================================
+ Hits 1284 1287 +3
Misses 4111 4111
+ Partials 16 15 -1
Continue to review full report at Codecov.
|
this.timer(willExpireAt, orderIdentifier); | ||
} else { | ||
this.set('getRemainingTime', '00:00'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bcz if we go to order/new page again after order is expired, timer again set getRemainingTime
which is different value and show this value for a sec and should show 00.00, and then transition to order/expired page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct
Fixes #5692
Short description of what this resolves:
Registration deadline not working
Changes proposed in this pull request:
Checklist
development
branch.