Skip to content

fix: Registration deadline not working #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2020
Merged

fix: Registration deadline not working #5695

merged 4 commits into from
Nov 19, 2020

Conversation

divyamtayal
Copy link
Member

@divyamtayal divyamtayal commented Nov 19, 2020

Fixes #5692

Short description of what this resolves:

Registration deadline not working

Changes proposed in this pull request:

  • Set status to expired

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/me28lff1p
✅ Preview: https://open-event-frontend-git-order-expired-5692.eventyay.now.sh

@divyamtayal divyamtayal changed the title Expired Order fix: Registration deadline not working Nov 19, 2020
@divyamtayal
Copy link
Member Author

Screenshot from 2020-11-19 18-05-32

Screenshot from 2020-11-19 18-08-24
@iamareebjamal Please see the changes

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #5695 (2888c3a) into development (9314043) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5695      +/-   ##
===============================================
+ Coverage        23.72%   23.77%   +0.04%     
===============================================
  Files              509      509              
  Lines             5411     5413       +2     
  Branches            59       59              
===============================================
+ Hits              1284     1287       +3     
  Misses            4111     4111              
+ Partials            16       15       -1     
Impacted Files Coverage Δ
app/components/forms/orders/order-form.js 0.00% <0.00%> (ø)
app/services/cache.ts 69.81% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9314043...2888c3a. Read the comment docs.

this.timer(willExpireAt, orderIdentifier);
} else {
this.set('getRemainingTime', '00:00');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

@divyamtayal divyamtayal Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bcz if we go to order/new page again after order is expired, timer again set getRemainingTime which is different value and show this value for a sec and should show 00.00, and then transition to order/expired page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

@iamareebjamal iamareebjamal merged commit c874482 into fossasia:development Nov 19, 2020
@divyamtayal divyamtayal deleted the order-expired-5692 branch November 23, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration deadline not working
2 participants