Skip to content

fix: Match color of activated "Event Types" boxes to other boxes #5681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 18, 2020
Merged

fix: Match color of activated "Event Types" boxes to other boxes #5681

merged 6 commits into from
Nov 18, 2020

Conversation

divyamtayal
Copy link
Member

Fixes #5675

Short description of what this resolves:

Matched Color with other UiDropdown

@vercel
Copy link

vercel bot commented Nov 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/iaz1un244
✅ Preview: https://open-event-frontend-git-match-color-5675.eventyay.vercel.app

@divyamtayal
Copy link
Member Author

Screenshot from 2020-11-18 01-26-26
@iamareebjamal Please see the changes

@divyamtayal divyamtayal changed the title Match Color Match color of activated "Event Types" boxes to other boxes Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #5681 (bcef5bd) into development (5d34f21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5681   +/-   ##
============================================
  Coverage        23.72%   23.72%           
============================================
  Files              498      498           
  Lines             5277     5277           
  Branches            47       47           
============================================
  Hits              1252     1252           
  Misses            4017     4017           
  Partials             8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d34f21...0825859. Read the comment docs.

@divyamtayal
Copy link
Member Author

Screenshot from 2020-11-18 04-08-59

@divyamtayal
Copy link
Member Author

@iamareebjamal This is best I think could be done to change the styling

@iamareebjamal
Copy link
Member

iamareebjamal commented Nov 18, 2020

Open in chrome and read the issue

image

@iamareebjamal iamareebjamal changed the title Match color of activated "Event Types" boxes to other boxes fix: Match color of activated "Event Types" boxes to other boxes Nov 18, 2020
@auto-label auto-label bot added the fix label Nov 18, 2020
@iamareebjamal iamareebjamal merged commit a067e20 into fossasia:development Nov 18, 2020
@divyamtayal
Copy link
Member Author

@iamareebjamal we could add box shadow as well, this looks even better

@iamareebjamal
Copy link
Member

Go ahead

@divyamtayal
Copy link
Member Author

@iamareebjamal In this PR only?

@iamareebjamal
Copy link
Member

No, this is already merged

@divyamtayal
Copy link
Member Author

divyamtayal commented Nov 18, 2020

No, this is already merged

@iamareebjamal okay so I should refer same issue #5675 and create new PR or create new issue then?

@iamareebjamal
Copy link
Member

same

@divyamtayal divyamtayal deleted the match-color-5675 branch November 18, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 1: Match color of activated "Event Types" boxes to other boxes
2 participants