Skip to content

feat: Implement deleting custom form field #5661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2020
Merged

feat: Implement deleting custom form field #5661

merged 4 commits into from
Nov 19, 2020

Conversation

codepool867
Copy link
Contributor

@codepool867 codepool867 commented Nov 16, 2020

Fixes #4596

Short description of what this resolves:

Implemented removing function for custom form field added.

Changes proposed in this pull request:

-Attendee form's template should be changed
-Remove action is inserted into the Attendee form component
-In custom table template, remove cell is activated

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6d7z15e4w
✅ Preview: https://open-event-frontend-git-issue2.eventyay.now.sh

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #5661 (d0c36a6) into development (efa056c) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5661      +/-   ##
===============================================
+ Coverage        23.73%   23.78%   +0.04%     
===============================================
  Files              498      509      +11     
  Lines             5275     5412     +137     
  Branches            47       59      +12     
===============================================
+ Hits              1252     1287      +35     
- Misses            4015     4110      +95     
- Partials             8       15       +7     
Impacted Files Coverage Δ
app/components/forms/wizard/attendee-step.js 0.00% <0.00%> (ø)
app/components/forms/wizard/custom-forms/table.ts 50.00% <ø> (ø)
app/components/footer-main.js 66.66% <0.00%> (-23.34%) ⬇️
app/components/forms/user-payment-info-form.js 26.66% <0.00%> (-1.91%) ⬇️
app/routes/application.js 83.78% <0.00%> (-1.59%) ⬇️
app/components/modals/modal-base.js 22.85% <0.00%> (-1.39%) ⬇️
app/router.js 100.00% <0.00%> (ø)
app/routes/index.js 78.57% <0.00%> (ø)
app/services/settings.js 66.66% <0.00%> (ø)
app/controllers/application.js 46.15% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa056c...d0c36a6. Read the comment docs.

@iamareebjamal
Copy link
Member

There needs to be a popup - "Are you sure you want to delete this?" before it gets deleted

@iamareebjamal iamareebjamal changed the title Implementing of deleting custom form field feat: Implement deleting custom form field Nov 19, 2020
@auto-label auto-label bot added the feature label Nov 19, 2020
@iamareebjamal iamareebjamal merged commit 816de6a into fossasia:development Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot remove or delete custom question
2 participants