Skip to content

fix: Improper Alignment of Order Now alert box #5556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 10, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 10, 2020

Fixes #5551

Short description of what this resolves:

This PR aligned login-signup-modal properly.

  • Reduce the size of the box
  • Increase spacing of squeezed text (gray and black text is very close without any spacing)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

before

dddddddddddd


eeeeeeeeee


ffffffffffffffff

after

a1


b1


c1

@vercel
Copy link

vercel bot commented Nov 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/bsovupnfb
✅ Preview: https://open-event-frontend-git-align-order-box.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #5556 (df16333) into development (ec21e62) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5556      +/-   ##
===============================================
- Coverage        23.76%   23.71%   -0.06%     
===============================================
  Files              498      498              
  Lines             5256     5255       -1     
  Branches            44       44              
===============================================
- Hits              1249     1246       -3     
- Misses            4001     4003       +2     
  Partials             6        6              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/routes/events/view/tickets/attendees/list.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec21e62...df16333. Read the comment docs.

@iamareebjamal
Copy link
Member

Not solved, it is still not aligned properly

@iamareebjamal
Copy link
Member

It looked like this previously. Please restore to this, reducing width won't solve the issue

image

@sachinchauhan2889 sachinchauhan2889 changed the title Wip: Improper Alignment of Order Now alert box fix: Improper Alignment of Order Now alert box Nov 10, 2020
@auto-label auto-label bot added the fix label Nov 10, 2020
@sachinchauhan2889
Copy link
Contributor Author

@iamareebjamal sir, implemented your suggested changes. Have a look at this.

@iamareebjamal iamareebjamal merged commit cbf8e2a into fossasia:development Nov 10, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the align-order-box branch November 13, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper Alignment of Order Now alert box
2 participants