Skip to content

fix: Public page destortion on different resolution #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 18, 2020
Merged

fix: Public page destortion on different resolution #5501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d5ad12
public page featured speaker resolutions resolution
maze-runnar Nov 6, 2020
00ee809
public page featured speaker resolutions resolution
maze-runnar Nov 6, 2020
a3c8501
fix
maze-runnar Nov 6, 2020
bb32254
sixth sense
maze-runnar Nov 7, 2020
ac12f5f
featured class
maze-runnar Nov 8, 2020
7320339
fix
maze-runnar Nov 8, 2020
4fa4b87
faded~
maze-runnar Nov 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/styles/components/speaker-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,15 @@
min-height: 100%;
object-fit: cover;
}

.featured-speaker {
height: auto;
overflow: hidden;
width: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a new class instead of modifying previous one

}

.featured-speaker img {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing the class, it will break every other place this class it used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that thumbnail class is also present their. I have added new class for featured -speaker only on public page in speaker-item.

.thumbnail-square {
  height: 300px;
  overflow: hidden;
}

.thumbnail-square img {
  min-height: 100%;
  object-fit: cover;
}

.featured-speaker {
  height: auto;
  overflow: hidden;
  width: 100%;
}

.featured-speaker img {
  min-height: 100%;
  min-width: 100%;
  object-fit: cover;
}

min-height: 100%;
min-width: 100%;
object-fit: cover;
}
2 changes: 1 addition & 1 deletion app/templates/components/public/speaker-item.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<UiAccordion>
<div class="title">
<div class="ui">
<div class="thumbnail-square">
<div class="featured-speaker">
<img alt="speaker" class="ui rounded image" src="{{if this.speaker.thumbnailImageUrl this.speaker.thumbnailImageUrl (if this.speaker.photoUrl this.speaker.photoUrl '/images/placeholders/avatar.png')}}">
</div>
<h3 class="ui centered header">
Expand Down