-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix issue with brackets and commas across platform #5485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lx1j6hc59 |
I can't see a single bracket fix |
@iamareebjamal maybe |
Definitely |
Codecov Report
@@ Coverage Diff @@
## development #5485 +/- ##
===============================================
- Coverage 23.25% 23.07% -0.18%
===============================================
Files 493 493
Lines 5182 5209 +27
Branches 38 38
===============================================
- Hits 1205 1202 -3
- Misses 3972 4002 +30
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No brackets fixed, e.g. issue with User(Email) sill there.
Also I am confused about the conversation. What does it mean as an answer "maybe"?
I will be looking for the bracketing issue as soon as possible. "maybe"- meant bracket error was missed by me |
Fixed in #5508 |
Fixes #5452
Short description of what this resolves:
fixed issue with brackets and commas across the platform without changing the functionality of the system.
Changes proposed in this pull request:
-fixed spacing before commas
-fixes no spacing in front of brackets
-fixes spacing issues with inverted commas
-added space where needed according to commas and brackets
Checklist
development
branch.