Skip to content

Fix issue with brackets and commas across platform #5485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix issue with brackets and commas across platform #5485

wants to merge 2 commits into from

Conversation

Chadha93
Copy link
Member

@Chadha93 Chadha93 commented Nov 4, 2020

Fixes #5452

Short description of what this resolves:

fixed issue with brackets and commas across the platform without changing the functionality of the system.

Changes proposed in this pull request:

-fixed spacing before commas
-fixes no spacing in front of brackets
-fixes spacing issues with inverted commas
-added space where needed according to commas and brackets

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests, and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lx1j6hc59
✅ Preview: https://open-event-frontend-git-development.eventyay.vercel.app

@iamareebjamal
Copy link
Member

I can't see a single bracket fix

@Chadha93
Copy link
Member Author

Chadha93 commented Nov 4, 2020

@iamareebjamal maybe

@iamareebjamal
Copy link
Member

Definitely

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #5485 into development will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5485      +/-   ##
===============================================
- Coverage        23.25%   23.07%   -0.18%     
===============================================
  Files              493      493              
  Lines             5182     5209      +27     
  Branches            38       38              
===============================================
- Hits              1205     1202       -3     
- Misses            3972     4002      +30     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/controllers/events/view/index.js 0.00% <0.00%> (ø)
app/controllers/events/view/scheduler.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/create.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/edit.js 0.00% <0.00%> (ø)
app/controllers/events/view/settings.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers/create.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers/edit.js 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e0cbd...c347cfa. Read the comment docs.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No brackets fixed, e.g. issue with User(Email) sill there.

Also I am confused about the conversation. What does it mean as an answer "maybe"?

@Chadha93
Copy link
Member Author

Chadha93 commented Nov 6, 2020

I will be looking for the bracketing issue as soon as possible. "maybe"- meant bracket error was missed by me

@iamareebjamal
Copy link
Member

Fixed in #5508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue with brackets and commas across platform
3 participants