Skip to content

fix: Show Social Links only on Event Pages that are listed on the left side bar #5467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 3, 2020

Fixes #4608

Short description of what this resolves:

Initially the Social Links(twitter) widget display on all the Event Pages including new-session , edit-session , new-speaker, edit-speaker pages. Left side bar not show on these listed pages but right twitter(social links) side bar widget is shown.

This PR solves this issue. Now the right side Social links widgets only visible on those pages which are listed in left side bar. Now the social Links widget not shown on new-session , edit-session , new-speaker, edit-speaker pages.

Controller of event public page contains displaySideMenu function which hide left side bar menu at these four pages. This PR uses this function to hide right side widget at these four pages.

Changes proposed in this pull request:

  • Social Links widgets only visible on the pages listed in left side bar.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

_screenshots

before

edit-session page
111

edit-speaker page
333333

after
new-speaker page
4444

edit-speaker page
777777

edit-session page
55555

@vercel
Copy link

vercel bot commented Nov 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/evsznbh1i
✅ Preview: https://open-event-frontend-git-fix-social-links.eventyay.vercel.app

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #5467 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5467   +/-   ##
============================================
  Coverage        23.23%   23.23%           
============================================
  Files              493      493           
  Lines             5169     5169           
  Branches            38       38           
============================================
  Hits              1201     1201           
  Misses            3963     3963           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e9f217...684e176. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 05c72b2 into fossasia:development Nov 3, 2020
@iamareebjamal
Copy link
Member

Great work

@sachinchauhan2889 sachinchauhan2889 deleted the fix-social-links branch November 3, 2020 16:29
akash2408 pushed a commit to akash2408/open-event-frontend that referenced this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call for Speakers: Only show Twitter Widget on Event Pages that are listed on the left side bar
3 participants