fix: call for speaker page messages #5415

maze-runnar · 2020-10-29T07:33:59Z

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-10-29T07:34:05Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6i2x716n7
✅ Preview: https://open-event-frontend-git-session-cfs-msg.eventyay.now.sh

codecov · 2020-10-29T07:46:40Z

Codecov Report

Merging #5415 into development will decrease coverage by 0.06%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #5415      +/-   ##
===============================================
- Coverage        23.29%   23.23%   -0.07%     
===============================================
  Files              492      493       +1     
  Lines             5147     5169      +22     
  Branches            38       38              
===============================================
+ Hits              1199     1201       +2     
- Misses            3943     3963      +20     
  Partials             5        5

Impacted Files	Coverage Δ
app/components/forms/orders/guest-order-form.js	`14.28% <0.00%> (-5.72%)`	⬇️
app/routes/account/danger-zone.js	`0.00% <0.00%> (ø)`
app/components/public/add-to-calender.ts	`9.09% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5dd30...a788d72. Read the comment docs.

iamareebjamal · 2020-10-29T12:26:39Z

app/templates/components/public/call-for-speakers.hbs

@@ -38,7 +38,11 @@
  {{/unless}}
 <div class="ui hidden divider"></div>
 {{#if this.isNewSession}}
-  <p>{{t 'No session have been submitted'}}</p>
+  {{#if this.authManager.currentUser.isVerified}}


If user is unverified, and they see the message Login to show your submitted sessions, it'd be confusing

if user is verified, they would see No sessions have been submitted

Sorry, I meant if user is unverified

app/templates/components/public/call-for-speakers.hbs

Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>

iamareebjamal · 2020-10-29T16:01:48Z

@maze-runnar Status?

maze-runnar · 2020-10-29T16:33:56Z

What's remaining in the PR?

iamareebjamal · 2020-10-29T16:37:39Z

#5415 (comment)

mariobehling · 2020-10-30T07:31:04Z

Ok, it should work like that:

Anonymous users show message: "You need to login to submit and view sessions."
Logged in user without sessions: "You have not submitted any sessions."
Logged in user with sessions: Show session names.

iamareebjamal · 2020-10-30T22:36:19Z

@maze-runnar Please fix this soon according to the above message

iamareebjamal · 2020-10-31T14:00:07Z

app/templates/components/public/call-for-speakers.hbs

@@ -38,14 +38,10 @@
  {{/unless}}
 <div class="ui hidden divider"></div>
 {{#if this.isNewSession}}
-  {{#if this.authManager.currentUser.isVerified}}
-    <p> {{t 'No sessions have been submitted'}} </p>
+  {{#if this.authManager.currentUser.email}}


Wouldn't just this.authManager.currentUser work?

iamareebjamal · 2020-10-31T14:01:25Z

@mariobehling Changing No sessions have been submitted to You have not submitted any sessions. will need change in translations. Is it required?

mariobehling · 2020-11-01T22:15:11Z

@mariobehling Changing No sessions have been submitted to You have not submitted any sessions. will need change in translations. Is it required?

It is always good to keep the translations up to date, yes.

iamareebjamal · 2020-11-01T23:15:22Z

I meant is the change required from No sessions have been submitted to You have not submitted any sessions since that'll mean previous translations becoming invalid, but I assume it is OK

app/templates/components/public/call-for-speakers.hbs

fix: call for speaker page messages

26315e0

vercel bot deployed to Preview October 29, 2020 07:34 View deployment

auto-label bot added the fix label Oct 29, 2020

iamareebjamal reviewed Oct 29, 2020

View reviewed changes

app/templates/components/public/call-for-speakers.hbs Outdated Show resolved Hide resolved

Update app/templates/components/public/call-for-speakers.hbs

abacf93

Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>

vercel bot deployed to Preview October 29, 2020 13:30 View deployment

Update call-for-speakers.hbs

0812c28

vercel bot deployed to Preview October 30, 2020 03:25 View deployment

Update call-for-speakers.hbs

882b090

vercel bot deployed to Preview October 31, 2020 09:25 View deployment

iamareebjamal reviewed Oct 31, 2020

View reviewed changes

iamareebjamal reviewed Nov 1, 2020

View reviewed changes

app/templates/components/public/call-for-speakers.hbs Outdated Show resolved Hide resolved

Update app/templates/components/public/call-for-speakers.hbs

a788d72

vercel bot deployed to Preview November 1, 2020 23:16 View deployment

iamareebjamal approved these changes Nov 1, 2020

View reviewed changes

iamareebjamal merged commit e0fd0a3 into fossasia:development Nov 1, 2020

maze-runnar deleted the session-cfs-msg branch November 2, 2020 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: call for speaker page messages #5415

fix: call for speaker page messages #5415

Uh oh!

maze-runnar commented Oct 29, 2020

Uh oh!

vercel bot commented Oct 29, 2020 •

edited

Loading

Uh oh!

codecov bot commented Oct 29, 2020 •

edited

Loading

Uh oh!

iamareebjamal Oct 29, 2020 •

edited

Loading

Uh oh!

maze-runnar Oct 29, 2020

Uh oh!

iamareebjamal Oct 29, 2020

Uh oh!

Uh oh!

iamareebjamal commented Oct 29, 2020

Uh oh!

maze-runnar commented Oct 29, 2020

Uh oh!

iamareebjamal commented Oct 29, 2020

Uh oh!

mariobehling commented Oct 30, 2020

Uh oh!

iamareebjamal commented Oct 30, 2020

Uh oh!

iamareebjamal Oct 31, 2020

Uh oh!

iamareebjamal commented Oct 31, 2020

Uh oh!

mariobehling commented Nov 1, 2020

Uh oh!

iamareebjamal commented Nov 1, 2020

Uh oh!

Uh oh!

Uh oh!

fix: call for speaker page messages #5415

fix: call for speaker page messages #5415

Uh oh!

Conversation

maze-runnar commented Oct 29, 2020

Checklist

Uh oh!

vercel bot commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iamareebjamal Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maze-runnar Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iamareebjamal commented Oct 29, 2020

Uh oh!

maze-runnar commented Oct 29, 2020

Uh oh!

iamareebjamal commented Oct 29, 2020

Uh oh!

mariobehling commented Oct 30, 2020

Uh oh!

iamareebjamal commented Oct 30, 2020

Uh oh!

iamareebjamal Oct 31, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Oct 31, 2020

Uh oh!

mariobehling commented Nov 1, 2020

Uh oh!

iamareebjamal commented Nov 1, 2020

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Oct 29, 2020 •

edited

Loading

codecov bot commented Oct 29, 2020 •

edited

Loading

iamareebjamal Oct 29, 2020 •

edited

Loading