Skip to content

fix: listing privacy shows error in wizard #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020
Merged

fix: listing privacy shows error in wizard #5215

merged 1 commit into from
Oct 1, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Oct 1, 2020

Fixes #5216

Screenshot from 2020-10-01 10-10-45

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8ufjjd5k8
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-privacy.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #5215 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5215   +/-   ##
============================================
  Coverage        22.63%   22.63%           
============================================
  Files              490      490           
  Lines             5201     5201           
  Branches            36       36           
============================================
  Hits              1177     1177           
  Misses            4019     4019           
  Partials             5        5           
Impacted Files Coverage Δ
.../components/forms/wizard/sessions-speakers-step.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9c907...283ccdb. Read the comment docs.

Copy link
Member

@Raunaksingh100 Raunaksingh100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz add the issue number in the pr ...

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change solves the issue

@iamareebjamal iamareebjamal merged commit 32bf7c8 into fossasia:development Oct 1, 2020
@maze-runnar maze-runnar deleted the privacy branch October 1, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wizard session step: privacy selection showing error
4 participants