-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: basic details image display enhancement #5109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/d7tymak9l |
Codecov Report
@@ Coverage Diff @@
## development #5109 +/- ##
===============================================
- Coverage 22.84% 22.80% -0.05%
===============================================
Files 489 489
Lines 5173 5169 -4
Branches 35 35
===============================================
- Hits 1182 1179 -3
+ Misses 3986 3985 -1
Partials 5 5
Continue to review full report at Codecov.
|
@mariobehling please confirm what of the above is requirement? |
Option 2 uses the space as desired, but you scaled the picture out of proportion. On the live pages of events the picture is sclaed and shown in proportion. Maybe check there how it is done. |
the images on event page has a greater height than here is. here it is only 150px |
Good. You understand what I mean then.
Please make the ratio on the wizard the same ratio as on the event page. |
When you upload an image, there is a preview feature. This preview feature shows the area that will be displayed on the live site. Here on the wizard the preview area should be displayed in the same way, please. |
For this, I have to increase the height from 150px, as on event page height of image is double near of upload page. This is looking good in this way. |
@mariobehling please confirm, should I change it to 250px? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Looks good to me now. Thank you.
Fixes #4983
Checklist
development
branch.