Skip to content

fix: basic details image display enhancement #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 24, 2020
Merged

fix: basic details image display enhancement #5109

merged 8 commits into from
Sep 24, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Sep 21, 2020

Fixes #4983

Screenshot from 2020-09-21 15-13-15
Screenshot from 2020-09-21 15-12-17

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/d7tymak9l
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-image.eventyay.vercel.app

@maze-runnar maze-runnar changed the title enh:basic details image display enhancement enh: basic details image display enhancement Sep 21, 2020
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #5109 into development will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5109      +/-   ##
===============================================
- Coverage        22.84%   22.80%   -0.05%     
===============================================
  Files              489      489              
  Lines             5173     5169       -4     
  Branches            35       35              
===============================================
- Hits              1182     1179       -3     
+ Misses            3986     3985       -1     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/controllers/admin/sales/invoices.js 0.00% <0.00%> (ø)
app/helpers/confirm.js 16.66% <0.00%> (+5.55%) ⬆️
app/components/widgets/forms/ticket-input.js 80.00% <0.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0fe64e...6b2a0d3. Read the comment docs.

@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-09-21 15-45-51
Screenshot from 2020-09-21 15-50-38

@mariobehling
Copy link
Member

Nice.

Now the actual goal of this issue is to show the uploaded background image in more or less the way it would look like on the live page. How can we get closer to achieving this?

In this image could you show the background image in the entire available width. There is a white space in the middle now.
Screenshot from 2020-09-21 15-45-51

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Sep 21, 2020

Now the actual goal of this issue is to show the uploaded background image in more or less the way it would look like on the live page. How can we get closer to achieving this?

is this kind of structure is needed?
Screenshot from 2020-09-21 16-45-52

this is similar to image that shows on public page. I can reduce height, but in card that image will not look good

option 2:
Screenshot from 2020-09-21 17-48-36

option 3:
Screenshot from 2020-09-21 17-53-08

@maze-runnar
Copy link
Contributor Author

@mariobehling please confirm what of the above is requirement?

@mariobehling
Copy link
Member

Option 2 uses the space as desired, but you scaled the picture out of proportion. On the live pages of events the picture is sclaed and shown in proportion. Maybe check there how it is done.

@maze-runnar
Copy link
Contributor Author

Option 2 uses the space as desired, but you scaled the picture out of proportion. On the live pages of events the picture is sclaed and shown in proportion. Maybe check there how it is done.

the images on event page has a greater height than here is. here it is only 150px

@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-09-22 16-31-14

@mariobehling
Copy link
Member

Option 2 uses the space as desired, but you scaled the picture out of proportion. On the live pages of events the picture is sclaed and shown in proportion. Maybe check there how it is done.

the images on event page has a greater height than here is. here it is only 150px

Good. You understand what I mean then.

  • What is the ratio on the event page?
  • What is the ratio on the wizard?

Please make the ratio on the wizard the same ratio as on the event page.

@mariobehling
Copy link
Member

When you upload an image, there is a preview feature. This preview feature shows the area that will be displayed on the live site.

Here on the wizard the preview area should be displayed in the same way, please.

@maze-runnar
Copy link
Contributor Author

public page:
Screenshot from 2020-09-22 16-56-11

Upload :
Screenshot from 2020-09-22 16-56-26

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Sep 22, 2020

Here on the wizard the preview area should be displayed in the same way, please.

For this, I have to increase the height from 150px, as on event page height of image is double near of upload page. This is looking good in this way.

@maze-runnar
Copy link
Contributor Author

on increasing height to 250 px -
Screenshot from 2020-09-22 17-10-43

@maze-runnar
Copy link
Contributor Author

@mariobehling please confirm, should I change it to 250px?

@mariobehling
Copy link
Member

Yes, seems a good idea to change the height accordingly.

Have a look at this though:

Screenshot from 2020-09-23 08-19-38

Screenshot from 2020-09-23 08-20-30

  • Please keep the original way for the logo.
  • Rename Background Image to "Header Image"
  • Rename "Select Event Image" to "Select Event Header Image"
  • Reduce the spacing above the image description
    Screenshot from 2020-09-23 08-23-28
  • Do not make image description bold
  • Ensure it looks fine on mobile view - there is no space below "Background Image" in mobile view
    Screenshot from 2020-09-23 08-24-45

@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-09-23 15-14-30

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Sep 23, 2020

  • Please keep the original way for the logo.
  • Rename Background Image to "Header Image"
  • Rename "Select Event Image" to "Select Event Header Image"
  • Reduce the spacing above the image description
  • Do not make image description bold
  • Ensure it looks fine on mobile view - there is no space below "Background Image" in mobile view

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me now. Thank you.

@iamareebjamal iamareebjamal changed the title enh: basic details image display enhancement fix: basic details image display enhancement Sep 24, 2020
@auto-label auto-label bot added the fix label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 1 Basic Details: Enhance Image Display and Info
3 participants