Skip to content

feat: Add video and slides to session #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 16, 2020

image
image
image

Fixes #5054

@vercel
Copy link

vercel bot commented Sep 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/c6m7lo695
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-video-slides.eventyay.vercel.app

@auto-label auto-label bot added the feature label Sep 16, 2020
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 12
           

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #5074 into development will decrease coverage by 0.02%.
The diff coverage is 53.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5074      +/-   ##
===============================================
- Coverage        22.82%   22.79%   -0.03%     
===============================================
  Files              489      489              
  Lines             5162     5173      +11     
  Branches            28       35       +7     
===============================================
+ Hits              1178     1179       +1     
- Misses            3980     3989       +9     
- Partials             4        5       +1     
Impacted Files Coverage Δ
app/routes/public/session/view.js 0.00% <0.00%> (ø)
app/components/public/session-item.js 22.22% <20.00%> (-17.78%) ⬇️
app/utils/url.ts 40.00% <77.77%> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36234dc...00ff5b0. Read the comment docs.

@iamareebjamal iamareebjamal merged commit d9f6713 into fossasia:development Sep 16, 2020
@iamareebjamal iamareebjamal deleted the video-slides branch September 16, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Session Page: Show social links, embed youtube or other video, add link to slides
3 participants