Skip to content

fix: Rerender calendar on timezone change #4991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 5, 2020

Fixes #4876

@vercel
Copy link

vercel bot commented Sep 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/nvjitesqo
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-calendar-timezone.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #4991 into development will increase coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4991   +/-   ##
============================================
  Coverage        22.66%   22.66%           
============================================
  Files              485      485           
  Lines             5149     5153    +4     
  Branches            21       21           
============================================
+ Hits              1167     1168    +1     
- Misses            3978     3981    +3     
  Partials             4        4           
Impacted Files Coverage Δ
app/components/schedule.ts 62.22% <25.00%> (-3.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3505a...a8cb82d. Read the comment docs.

@mariobehling
Copy link
Member

Nice!

@iamareebjamal iamareebjamal changed the title fix: Rerendar calendar on timezone change fix: Rerender calendar on timezone change Sep 5, 2020
@iamareebjamal iamareebjamal merged commit 1207db6 into fossasia:development Sep 5, 2020
@iamareebjamal iamareebjamal deleted the calendar-timezone branch September 5, 2020 10:27
@mariobehling
Copy link
Member

The calendar view has some issues left, that might be related #4996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule Calendar View: Changing Timezone can Result in Disappearing Sessions from Schedule
2 participants