Skip to content

fix: adding allowClear to make fields null again #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020
Merged

fix: adding allowClear to make fields null again #4970

merged 1 commit into from
Sep 4, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #2302

captured (2)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6k0xfgflb
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-12.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 4, 2020
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #4970 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4970   +/-   ##
============================================
  Coverage        22.83%   22.83%           
============================================
  Files              485      485           
  Lines             5142     5142           
  Branches            21       21           
============================================
  Hits              1174     1174           
  Misses            3964     3964           
  Partials             4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09103b8...3741580. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 261dfde into fossasia:development Sep 4, 2020
@maze-runnar maze-runnar deleted the patch-12 branch September 4, 2020 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Type,Event Topic,Event subtopic, License cannot be made null once set
2 participants