Skip to content

feat: only request to fill username for social links in forms #4943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

snitin315
Copy link
Member

Refers #4609

Short description of what this resolves:

Made social media links on all forms in a way that users only need to add their username or other short forms.

Changes proposed in this pull request:

Screenshot at 2020-09-02 20-30-14

Additional info

@vercel vercel bot temporarily deployed to Preview September 2, 2020 15:14 Inactive
@snitin315 snitin315 force-pushed the feat/social-username branch from 52e299d to 6c4799e Compare September 2, 2020 15:14
@vercel
Copy link

vercel bot commented Sep 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/4j34nlji5
✅ Preview: https://open-event-frontend-git-fork-snitin315-feat-social-username.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #4943 into development will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4943      +/-   ##
===============================================
- Coverage        22.86%   22.85%   -0.02%     
===============================================
  Files              484      484              
  Lines             5129     5133       +4     
  Branches            18       18              
===============================================
  Hits              1173     1173              
- Misses            3952     3956       +4     
  Partials             4        4              
Impacted Files Coverage Δ
app/components/widgets/forms/link-input.js 27.58% <0.00%> (-4.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bb963...b3f5592. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 9f9c329 into fossasia:development Sep 2, 2020
@snitin315 snitin315 deleted the feat/social-username branch September 3, 2020 01:49
@mariobehling
Copy link
Member

The recent changes resulted in only covering very few social media services. Services that were previously covered in this feature are no longer covered, e.g.

  • GitHub
  • Gitlab
  • Vimeo
  • Blog
  • Flickr
  • Any other major social media platform
  • Custom (User should be able to add own detail here)

Please add other major services and enable the user to use "Custom".

E.g. = example. It does not mean only the mentioned services should be covered. All services that were previously covered should still be covered after the changes. Therefore reopening this issue. Thanks.

iamareebjamal added a commit to iamareebjamal/open-event-frontend that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants