Skip to content

fix: overlapping of the logo #4939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Conversation

Raunaksingh100
Copy link
Member

@Raunaksingh100 Raunaksingh100 commented Sep 2, 2020

Description---

The logo is overlapping to the navbar and covering the half of the content Due to the large size of the width,,,
i reduced the width of the logo by doing this the bug fixed and it doesnot affect the DESKTOP SITE and fixed the MOBILE SITE
plz see in the screenshot given below for the better understanding.

Fixes

#4872

Screenshot for Mobile Site

1.

fixed moto

2.

fixe3d gs5

Screenshot for the Desktop Site

issue desk

@iamareebjamal , @snitin315
plz review-

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/27h59vu3j
✅ Preview: https://open-event-frontend-git-fork-raunaksingh100-dev.eventyay.vercel.app

@Raunaksingh100 Raunaksingh100 changed the title fix the overlapping of the logo fix:The overlapping of the logo Sep 2, 2020
@auto-label auto-label bot added the fix label Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #4939 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4939   +/-   ##
============================================
  Coverage        22.89%   22.89%           
============================================
  Files              489      489           
  Lines             5162     5162           
  Branches            35       35           
============================================
  Hits              1182     1182           
  Misses            3975     3975           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ae6bb...90c0f98. Read the comment docs.

Copy link

@cggvuhh cggvuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamareebjamal iamareebjamal changed the title fix:The overlapping of the logo fix: overlapping of the logo Sep 20, 2020
@iamareebjamal iamareebjamal merged commit 77ccdad into fossasia:development Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants