Skip to content

fix: increase page size to 21 for speakers #4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2020
Merged

fix: increase page size to 21 for speakers #4932

merged 1 commit into from
Sep 2, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4866
Making page size to 21 is giving better performance than 12 in terms of breaks while scrolling on a pageSize of 12 and total time also. And Also loads fast. So this is kind of trade of between total time and loading time I guess. So I found pageSize 21 as a best option.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/cyapwh4ei
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-12.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #4932 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4932   +/-   ##
============================================
  Coverage        22.85%   22.85%           
============================================
  Files              483      483           
  Lines             5123     5123           
  Branches            18       18           
============================================
  Hits              1171     1171           
  Misses            3948     3948           
  Partials             4        4           
Impacted Files Coverage Δ
app/routes/public/speakers.js 33.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcce5db...d665baa. Read the comment docs.

@iamareebjamal
Copy link
Member

I still think it doesn't trigger at the correct time but merging as a workaround for now. Let's see what else can be done later

@iamareebjamal iamareebjamal changed the title fix: increasing page size to 21 for speakers fix: increase page size to 21 for speakers Sep 2, 2020
@iamareebjamal iamareebjamal merged commit b1e1734 into fossasia:development Sep 2, 2020
@maze-runnar maze-runnar deleted the patch-12 branch September 2, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Speakers and Schedule Page: No Lazy Loading, it Slows Down Users Too Much
2 participants