Skip to content

fix: Standardize color utils and speaker session UI, timezone #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 23, 2020

  • Refactor all color utils in one place
  • Adjust threshold for switching colors
  • Deduplicate color helpers
  • Make session list UI in speakers aligned with global UI
  • Correct timezone being used in session list in speakers

Fixes #4846

Before:
image
image

After:
image
image

@auto-label auto-label bot added the fix label Aug 23, 2020
@vercel
Copy link

vercel bot commented Aug 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/bjptky66c
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-color-refactor.eventyay.vercel.app

@iamareebjamal iamareebjamal changed the title fix: Standardize color utils and UI fix: Standardize color utils and speaker session UI, timezone Aug 23, 2020
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ app/utils/color.ts  -1
         

See the complete overview on Codacy

@iamareebjamal iamareebjamal merged commit 3cd3ad6 into fossasia:development Aug 23, 2020
@iamareebjamal iamareebjamal deleted the color-refactor branch August 23, 2020 04:02
@mariobehling
Copy link
Member

Very good attention to detail. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong timezone in session list under speaker section
3 participants