fix: show globe icon for general web links #4809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/n1tsqagcz |
Codecov Report
@@ Coverage Diff @@
## development #4809 +/- ##
===============================================
- Coverage 23.50% 23.49% -0.02%
===============================================
Files 481 481
Lines 5079 5083 +4
Branches 16 16
===============================================
Hits 1194 1194
- Misses 3881 3885 +4
Partials 4 4
Continue to review full report at Codecov.
|
app/models/social-link.js
Outdated
| @@ -17,7 +17,13 @@ export default ModelBase.extend({ | |||
| // and non-null name is being sent from API, for some reason, for certain events, | |||
| // this throws an error, so we check first if name exists | |||
| // https://github.com/fossasia/open-event-frontend/issues/4777 | |||
| return this.name && this.name.trim().toLowerCase(); | |||
|
|
|||
| let normalizedName = this.name.trim().toLowerCase(); | |||
There was a problem hiding this comment.
Boom goes the last change. Read the comment above
snitin315
commented
Aug 19, 2020
snitin315
force-pushed
the
fix/social-icon
branch
from
7aa3fc0 to
7d14aaa
Compare
snitin315
force-pushed
the
fix/social-icon
branch
from
7d14aaa to
c9442e4
Compare
Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
iamareebjamal
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4802
Short description of what this resolves:
Show
globeicon if the URL is not a standard social media URL.Changes proposed in this pull request:
Checklist
developmentbranch.