-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: introducing tracks for sessions #4796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/gtt2ns3vi |
@iamareebjamal please review. |
video of working - https://youtu.be/gdotFtocMjc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement the design more closely to the website generator. Do not use the track color for the entire area. Compare https://summit.fossasia.org/event/schedule.html
In the screenshots, I dont see if all details are present. Here is the list what should definitely be there:
|
@mariobehling I have updated the changes . please take a look - https://youtu.be/gdotFtocMjc, |
@iamareebjamal @mariobehling please take a look at these changes - |
Don't show time in card. Try to mimick https://summit.fossasia.org/event/schedule.html as much as you can. Remove the outer card as well Expanded session should show these details: #4796 (comment) Not in the old UI. New UI is set to replace the old UI. So all the information should be available in the new UI itself including the date switcher as well |
@iamareebjamal i have made it similar to https://summit.fossasia.org/event/schedule.html . |
Looks good. Please remove the time from card, only session box should be in a card. I'll review the implementation soon |
ok |
Also, use |
which color? |
@iamareebjamal please take a look - |
Issues
======
- Added 1
Complexity increasing per file
==============================
- app/controllers/public/sessions/list.js 1
See the complete overview on Codacy |
const arr = new Array(); | ||
const difference = (this.model.event.endsAt).diff(this.model.event.startsAt, 'days'); | ||
for (let i = 0; i <= Math.abs(difference); i++) { | ||
arr.push(moment(this.model.event.startsAt).add(i, 'days').toISOString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Mixed spaces and tabs.
Session Title and subtitle should be of same color. And there is still card nesting. The color card is sitting inside a white card |
No there is no card nesting, this is default accordion. And if I remove border lines, UI looks unclear. |
they should be white ? |
Yes |
I think the implementation here is more closely related to this issue #4807 It seems you are implementing the tracks view page. What is the difference between the different schedule pages?
|
Please get rid of box lines. You can move the time on the left to match the position of the text on the right hand side. Just keep the lines minimal as in the website generated pages. The tracks page also lists the track name above each track list. |
Great work @maze-runnar. I'm going to take your UI and logic to implement #4808 as it is high priority and to be fixed by tomorrow. And then later, we can use the same components to implement track and schedule view. Thanks for doing the hard work for me |
UI changed now |
Adding more than 1 speaker for a session with track -


Checklist
development
branch.