Skip to content

feat: introducing tracks for sessions #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

feat: introducing tracks for sessions #4796

wants to merge 5 commits into from

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Aug 18, 2020

Screenshot from 2020-08-18 23-41-44
Screenshot from 2020-08-18 23-41-41
Screenshot from 2020-08-18 23-41-33

Adding more than 1 speaker for a session with track -
Screenshot from 2020-08-18 23-57-54
Screenshot from 2020-08-18 23-57-50

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/gtt2ns3vi
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-tracks.eventyay.vercel.app

@maze-runnar
Copy link
Contributor Author

@iamareebjamal please review.

@maze-runnar
Copy link
Contributor Author

video of working - https://youtu.be/gdotFtocMjc

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the design more closely to the website generator. Do not use the track color for the entire area. Compare https://summit.fossasia.org/event/schedule.html

Screenshot from 2020-08-20 10-00-12

@mariobehling
Copy link
Member

In the screenshots, I dont see if all details are present. Here is the list what should definitely be there:

  • Session Title
  • Track
  • Type (workshop, talk etc.)
  • Speaker Name and links
  • Time and Date
  • Room
  • Description

@maze-runnar
Copy link
Contributor Author

In the screenshots, I dont see if all details are present. Here is the list what should definitely be there:

  • Session Title
  • Track
  • Type (workshop, talk etc.)
  • Speaker Name and links
  • Time and Date
  • Room
  • Description

@mariobehling I have updated the changes . please take a look - https://youtu.be/gdotFtocMjc,

@maze-runnar
Copy link
Contributor Author

@iamareebjamal @mariobehling please take a look at these changes -
Screenshot from 2020-08-20 17-01-06
Screenshot from 2020-08-20 17-01-00

@iamareebjamal
Copy link
Member

Don't show time in card. Try to mimick https://summit.fossasia.org/event/schedule.html as much as you can. Remove the outer card as well

Expanded session should show these details: #4796 (comment)

Not in the old UI. New UI is set to replace the old UI. So all the information should be available in the new UI itself including the date switcher as well

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Aug 20, 2020

@iamareebjamal i have made it similar to https://summit.fossasia.org/event/schedule.html .

Screenshot from 2020-08-20 18-48-41

@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-08-20 18-48-50

@iamareebjamal
Copy link
Member

Looks good. Please remove the time from card, only session box should be in a card. I'll review the implementation soon

@maze-runnar
Copy link
Contributor Author

Looks good. Please remove the time from card, only session box should be in a card. I'll review the implementation soon

ok

@iamareebjamal
Copy link
Member

Also, use isLight utility function to change the text color in the card

@maze-runnar
Copy link
Contributor Author

Also, use isLight utility function to change the text color in the card

which color?

@maze-runnar
Copy link
Contributor Author

@iamareebjamal please take a look -
Screenshot from 2020-08-20 19-29-19
Screenshot from 2020-08-20 19-29-16

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

Complexity increasing per file
==============================
- app/controllers/public/sessions/list.js  1
         

See the complete overview on Codacy

const arr = new Array();
const difference = (this.model.event.endsAt).diff(this.model.event.startsAt, 'days');
for (let i = 0; i <= Math.abs(difference); i++) {
arr.push(moment(this.model.event.startsAt).add(i, 'days').toISOString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Mixed spaces and tabs.

@iamareebjamal
Copy link
Member

Session Title and subtitle should be of same color. And there is still card nesting. The color card is sitting inside a white card

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Aug 20, 2020

Session Title and subtitle should be of the same color. And there is still card nesting. The color card is sitting inside a white card

No there is no card nesting, this is default accordion. And if I remove border lines, UI looks unclear.

@maze-runnar
Copy link
Contributor Author

Session Title and subtitle

they should be white ?

@iamareebjamal
Copy link
Member

Yes

@mariobehling
Copy link
Member

mariobehling commented Aug 20, 2020

I think the implementation here is more closely related to this issue #4807

It seems you are implementing the tracks view page.

What is the difference between the different schedule pages?

  1. Schedule Page in calendar view (in future different views should be switchable)
    1.a) Tracks Page - all sessions are sorted in list view according to date, time and track
    1.b) Rooms Page - all sessions are sorted in list view according to date, time and room
  2. Session Page - this page shows all sessions in alphabetical order (including accepted and confirmed ones that are not yet scheduled)

@mariobehling
Copy link
Member

mariobehling commented Aug 20, 2020

Please get rid of box lines. You can move the time on the left to match the position of the text on the right hand side.

Just keep the lines minimal as in the website generated pages. The tracks page also lists the track name above each track list.
Compare: https://sched.eventyay.com/FOSSASIASummit/tracks.html

Screenshot from 2020-08-20 21-14-18

Screenshot from 2020-08-20 21-20-27

@iamareebjamal
Copy link
Member

Great work @maze-runnar. I'm going to take your UI and logic to implement #4808 as it is high priority and to be fixed by tomorrow. And then later, we can use the same components to implement track and schedule view.

Thanks for doing the hard work for me

@iamareebjamal
Copy link
Member

UI changed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants