Skip to content

feat: Add session notify dialog #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 10, 2020

Fixes #4604

image

@vercel
Copy link

vercel bot commented Aug 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/a28aubl6q
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-email-dialog.eventyay.vercel.app

@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2020

This pull request introduces 1 alert when merging 6f8ec0f into 03b11e2 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@iamareebjamal iamareebjamal changed the title wip: Add session notify dialog feat: Add session notify dialog Aug 11, 2020
@auto-label auto-label bot added the feature label Aug 11, 2020
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/integration/components/ui-table/cell/events/view/sessions/cell-notify-test.js  1
- app/components/ui-table/cell/events/view/sessions/cell-notify.js  1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #4733 into development will decrease coverage by 0.10%.
The diff coverage is 8.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4733      +/-   ##
===============================================
- Coverage        23.10%   23.00%   -0.11%     
===============================================
  Files              476      478       +2     
  Lines             4981     5017      +36     
  Branches             8        8              
===============================================
+ Hits              1151     1154       +3     
- Misses            3829     3862      +33     
  Partials             1        1              
Impacted Files Coverage Δ
app/controllers/events/view/sessions/list.js 0.00% <ø> (ø)
app/components/modals/session-notify-modal.js 6.06% <6.06%> (ø)
.../ui-table/cell/events/view/sessions/cell-notify.js 33.33% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f4dcc...105cd2d. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 25af7b7 into fossasia:development Aug 11, 2020
@iamareebjamal iamareebjamal deleted the email-dialog branch August 11, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Status Change: Send Status Change with Email
2 participants