-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: Add margin around speaker name and make text selectable #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/fil8r2nn9 |
The linked URL is not he meant by expanded session in sessions page. The URL you linked is session URL for speakers, not the public sessions page |
This is the sessions page: https://eventyay.com/e/8fa7fd14/sessions/all |
Then it will be same for each session. Isn't it |
Codecov Report
@@ Coverage Diff @@
## development #4715 +/- ##
===============================================
- Coverage 23.53% 23.10% -0.44%
===============================================
Files 481 476 -5
Lines 5085 4981 -104
Branches 16 8 -8
===============================================
- Hits 1197 1151 -46
+ Misses 3884 3829 -55
+ Partials 4 1 -3
Continue to review full report at Codecov.
|
The expected outcome is to take them to same page but the session must be expanded and page scrolled to that position. Same as when you click on |
ea1dc39
to
c647ed8
Compare
Fixes #4000
Short description of what this resolves:
Speaker name was too close to speaker image, there was no link on session and text was not selectable.
Changes proposed in this pull request:
Before :
After :
Checklist
development
branch.