Skip to content

fix: Add margin around speaker name and make text selectable #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Aug 5, 2020

Fixes #4000

Short description of what this resolves:

Speaker name was too close to speaker image, there was no link on session and text was not selectable.

Changes proposed in this pull request:

  • Increase gap between speaker's image and name.
  • Make text selectable.
  • Link speaker sessions.
Before :

speaker-space-link-selectable-before

After :

speaker-space-link-selectable-after

link-speaker-sessions

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/fil8r2nn9
✅ Preview: https://open-event-frontend-git-fork-haider8-issue-4000.eventyay.vercel.app

@iamareebjamal
Copy link
Member

The linked URL is not he meant by expanded session in sessions page. The URL you linked is session URL for speakers, not the public sessions page

@iamareebjamal
Copy link
Member

This is the sessions page: https://eventyay.com/e/8fa7fd14/sessions/all

@Haider8
Copy link
Contributor Author

Haider8 commented Aug 5, 2020

Then it will be same for each session. Isn't it

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #4715 into development will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4715      +/-   ##
===============================================
- Coverage        23.53%   23.10%   -0.44%     
===============================================
  Files              481      476       -5     
  Lines             5085     4981     -104     
  Branches            16        8       -8     
===============================================
- Hits              1197     1151      -46     
+ Misses            3884     3829      -55     
+ Partials             4        1       -3     
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/components/scheduler/unscheduled-session.js 77.77% <0.00%> (-2.23%) ⬇️
app/router.js 100.00% <0.00%> (ø)
app/sentry.ts 0.00% <0.00%> (ø)
app/models/social-link.js 0.00% <0.00%> (ø)
app/helpers/general-date.js 100.00% <0.00%> (ø)
app/mixins/notifications.js 0.00% <0.00%> (ø)
app/controllers/orders/new.js 0.00% <0.00%> (ø)
app/routes/public/schedule.js 0.00% <0.00%> (ø)
app/routes/public/speakers.js 0.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6861fb5...c647ed8. Read the comment docs.

@iamareebjamal
Copy link
Member

The expected outcome is to take them to same page but the session must be expanded and page scrolled to that position. Same as when you click on Getting Here on this page https://eventyay.com/e/8fa7fd14

@iamareebjamal iamareebjamal changed the title fix: Add margin around speaker name, link session and make text selectable fix: Add margin around speaker name and make text selectable Aug 20, 2020
@iamareebjamal iamareebjamal merged commit ff4d641 into fossasia:development Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speaker name too close to picture and text cannot be selected
2 participants