Skip to content

fix: Handle exception while serialising session #4707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

divs4debu
Copy link
Contributor

@divs4debu divs4debu commented Aug 4, 2020

Fixes #4706

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Aug 4, 2020
@vercel
Copy link

vercel bot commented Aug 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/f2hn378pg
✅ Preview: https://open-event-frontend-git-fork-divs4debu-handleexceptioninsession.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/serializers/session.js  2
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #4707 into development will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4707      +/-   ##
===============================================
- Coverage        23.11%   23.08%   -0.04%     
===============================================
  Files              476      476              
  Lines             4975     4982       +7     
  Branches             8        8              
===============================================
  Hits              1150     1150              
- Misses            3824     3831       +7     
  Partials             1        1              
Impacted Files Coverage Δ
app/components/forms/wizard/basic-details-step.js 24.39% <0.00%> (-0.31%) ⬇️
app/mixins/event-wizard.js 1.14% <0.00%> (-0.08%) ⬇️
app/serializers/session.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1619a8...8718dc1. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 6feed0e into fossasia:development Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session save throwing error when submitting
3 participants